-
Notifications
You must be signed in to change notification settings - Fork 95
Update Rocm base image for release 2025a #956
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey Diamond! Added a few comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested the images:
quay.io/opendatahub/workbench-images:rocm-jupyter-tensorflow-ubi9-python-3.11-pr-956
quay.io/opendatahub/workbench-images:rocm-jupyter-pytorch-ubi9-python-3.11-pr-956
(app-root) module avail
---------------------------------------------------------------------------------------------- /usr/share/Modules/modulefiles ----------------------------------------------------------------------------------------------
dot module-git module-info modules null rocm/6.2.4 use.own
All looks great, we just need to make the same change in
- jupyter/minimal/Dockerfile.rocm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Tested the minimal Rocm
quay.io/opendatahub/workbench-images:rocm-jupyter-minimal-ubi9-python-3.11-pr-956
version, rocm-smi, rocminfo : ✔️
@dibryant: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jiridanek The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
FIxes for https://issues.redhat.com/browse/RHOAIENG-19482
Description
Update ROCm base image
How Has This Been Tested?
podman build -t (tagname) -f jupyter/rocm/pytorch/ubi9-python-3.11/Dockerfile.rocm .
Merge criteria: