Skip to content

Follow up to update the commit file properly based on image change #1021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 16, 2025

Conversation

atheo89
Copy link
Member

@atheo89 atheo89 commented Apr 16, 2025

Description

Follow up to update the commit file properly based on image change.

follow up to cover this flow here: #1019 (comment)

Now it updates the commit.env file only in case that the corresponding image updated on the params.env

How Has This Been Tested?

Tested locally with a modified manifest folder for shake of time.
atheo89#50

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@openshift-ci openshift-ci bot requested review from harshad16 and jiridanek April 16, 2025 15:56
Copy link
Contributor

openshift-ci bot commented Apr 16, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign atheo89 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jiridanek
Copy link
Member

/lgtm

@daniellutz
Copy link
Contributor

/lgtm

@daniellutz daniellutz merged commit b38759a into opendatahub-io:main Apr 16, 2025
16 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants