-
Notifications
You must be signed in to change notification settings - Fork 83
NO-JIRA: chore - update the default image version in Makefile; add links to our contrib guide #1011
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -19,7 +19,7 @@ endif | |||
.RECIPEPREFIX = | |||
|
|||
IMAGE_REGISTRY ?= quay.io/opendatahub/workbench-images | |||
RELEASE ?= 2024b | |||
RELEASE ?= 2025a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shall I review also our ocp-ci jobs? Do we e.g. care about this: https://github.com/openshift/release/blob/master/ci-operator/config/opendatahub-io/notebooks/.config.prowgen#L8 ?
/lgtm and @atheo89 also seems agreeable in https://redhat-internal.slack.com/archives/C060A5FJEAD/p1744195078043939 we can discuss adding label as separate discussion office hours are next monday, that feels too long to wait for resolution of this |
/lgtm |
@jstourac: you cannot LGTM your own PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jstourac The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/override ci/prow/images |
@jstourac: Overrode contexts on behalf of jstourac: ci/prow/images In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/lgtm |
ceced17
into
opendatahub-io:main
Description
How Has This Been Tested?
Merge criteria: