Skip to content

NO-JIRA: chore - update the default image version in Makefile; add links to our contrib guide #1011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 10, 2025

Conversation

jstourac
Copy link
Member

@jstourac jstourac commented Apr 9, 2025

Description

  • NO-JIRA: chore(Makefile): update the default image version
  • NO-JIRA: chore(CONTRIBUTING.md): add links to our openshift-ci configs

How Has This Been Tested?

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@jstourac jstourac self-assigned this Apr 9, 2025
@openshift-ci openshift-ci bot requested review from caponetto and daniellutz April 9, 2025 10:06
@openshift-ci openshift-ci bot added the size/xs label Apr 9, 2025
@@ -19,7 +19,7 @@ endif
.RECIPEPREFIX =

IMAGE_REGISTRY ?= quay.io/opendatahub/workbench-images
RELEASE ?= 2024b
RELEASE ?= 2025a
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@openshift-ci openshift-ci bot added size/xs and removed size/xs labels Apr 9, 2025
@jstourac jstourac changed the title Updates NO-JIRA: chore - update the default image version in Makefile; add links to our contrib guide Apr 9, 2025
@openshift-ci openshift-ci bot added size/xs and removed size/xs labels Apr 9, 2025
@jiridanek
Copy link
Member

/lgtm

and @atheo89 also seems agreeable in https://redhat-internal.slack.com/archives/C060A5FJEAD/p1744195078043939

we can discuss adding label as separate discussion

office hours are next monday, that feels too long to wait for resolution of this

@jstourac
Copy link
Member Author

/lgtm
/approve

Copy link
Contributor

openshift-ci bot commented Apr 10, 2025

@jstourac: you cannot LGTM your own PR.

In response to this:

/lgtm
/approve

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Contributor

openshift-ci bot commented Apr 10, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jstourac

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jstourac
Copy link
Member Author

/override ci/prow/images

Copy link
Contributor

openshift-ci bot commented Apr 10, 2025

@jstourac: Overrode contexts on behalf of jstourac: ci/prow/images

In response to this:

/override ci/prow/images

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jiridanek
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Apr 10, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit ceced17 into opendatahub-io:main Apr 10, 2025
10 checks passed
@jstourac jstourac deleted the updates branch April 10, 2025 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants