[1.3] ci: bump golangci-lint to v2.1 #4754
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(The current v2.1 release is v2.1.5 as of today). Signed-off-by: Kir Kolyshkin <[email protected]> (cherry picked from commit b0aa863) Signed-off-by: Kir Kolyshkin <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
This PR backports changes to the release-1.3 branch with a focus on CI configuration updates (notably bumping golangci-lint to v2.1) and documentation improvements. Key changes include updating function comments for better clarity, adjusting environment variable preparation order during container initialization, and revising CI workflow configurations.
Reviewed Changes
Copilot reviewed 35 out of 40 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| libcontainer/intelrdt/intelrdt.go | Updated function comments for consistent godoc style. |
| libcontainer/intelrdt/cmt.go | Renamed comment to “IsCMTEnabled” for consistency. |
| libcontainer/init_linux.go | Removed an early call to prepareEnv and moved environment setup to finalizeNamespace. |
| libcontainer/env_test.go | Added test cases to verify proper handling of HOME values. |
| libcontainer/env.go | Adjusted environment deduplication logic to treat empty HOME values appropriately. |
| libcontainer/criu_linux.go | Adjusted CRIU-related conditions to add a time namespace when applicable. |
| libcontainer/capabilities/capabilities.go | Updated function comment to “ApplyCaps” to better clarify its functionality. |
| docs/spec-conformance.md | Updated the OCI Runtime Spec version from v1.2.0 to v1.2.1. |
| checkpoint.go | Modified the container destruction condition for checkpoints; the logic remains equivalent. |
| CHANGELOG.md | Updated changelog entries to reflect the improvements and configuration changes. |
| .golangci.yml / .golangci-extra.yml | Upgraded linters and adjusted configuration for improved code quality checks. |
| .github/workflows/validate.yml / test.yml | Upgraded relevant actions (including golangci-lint and shellcheck) and added a Fedora job setup. |
| .cirrus.yml | Simplified task definitions to better align with the current CI platform capabilities. |
Files not reviewed (5)
- Dockerfile: Language not supported
- Makefile: Language not supported
- VERSION: Language not supported
- Vagrantfile.fedora: Language not supported
- go.mod: Language not supported
Comments suppressed due to low confidence (1)
libcontainer/init_linux.go:324
- The removal of the early prepareEnv call from container initialization may impact components expecting the environment to be set up before entering the container jail. Verify that moving this call to finalizeNamespace is intentional and that it does not create side effects.
env, err := prepareEnv(config.Env, config.UID)
AkihiroSuda
approved these changes
Apr 30, 2025
|
close/reopen to kick ci |
cyphar
approved these changes
May 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #4747 to release-1.3.