ci bumps #4344
Merged
ci bumps #4344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code already checked if err == nil above, so the linter complains:
> libcontainer/container_linux.go:534:18: nilness: tautological condition: non-nil != nil (govet)
> } else if err != nil {
> ^
Fix the issue, enable the check.
Signed-off-by: Kir Kolyshkin <[email protected]>
This function never returns error since 2016 (commit 556f798), so let's remove it. Signed-off-by: Kir Kolyshkin <[email protected]>
Signed-off-by: Kir Kolyshkin <[email protected]>
AkihiroSuda
approved these changes
Jul 26, 2024
akhilerm
reviewed
Jul 29, 2024
|
@opencontainers/runc-maintainers it's a pity this relatively easy to review PR sits in review for so long I forgot I created it and caught myself wanting to create this again (as I have newer golangci-lint installed locally and it shows some warnings fixed here). PTAL. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bumps golangci-lint, adds another sub-linter for govet (nilness), and fixes the issues found by new/updated linters.