Correct tmpfs mount for cgroup #127
Conversation
Fixes: moby/moby#14543 Fixes: moby/moby#14610 Before this, we got mount info in container: ``` sysfs /sys sysfs ro,seclabel,nosuid,nodev,noexec,relatime 0 0 /sys/fs/cgroup tmpfs rw,seclabel,nosuid,nodev,noexec,relatime 0 0 cgroup /sys/fs/cgroup/cpuset cgroup rw,relatime,cpuset 0 0 ``` It has no mount source, so in `parseInfoFile` in Docker code, we'll get: ``` Error found less than 3 fields post '-' in "84 83 0:41 / /sys/fs/cgroup rw,nosuid,nodev,noexec,relatime - tmpfs rw,seclabel" ``` After this fix, we have mount info corrected: ``` sysfs /sys sysfs ro,seclabel,nosuid,nodev,noexec,relatime 0 0 tmpfs /sys/fs/cgroup tmpfs rw,seclabel,nosuid,nodev,noexec,relatime 0 0 cgroup /sys/fs/cgroup/cpuset cgroup rw,relatime,cpuset 0 0 ``` Signed-off-by: Qiang Huang <[email protected]>
|
LGTM |
|
This is still not full fix. There will be still issues with containers in containers. I'll show you tomorrow what I have. |
|
Yeah I figured that it doesn't solve everything but will be part of the final solution. Sent from my iPhone
|
|
I guess we can just wait for your fix tomorrow. Sent from my iPhone
|
|
Yeah, this fix is right anyway. Probably it's better to make it step by step :) |
|
What's the plan to get this fix into docker/master as moby/moby#13312 wasn't reverted? I'm working on some fixes to the docker-py tests and am hitting what is almost certainly the same thing - Cannot start container. Error found less than 3 fields post '-' in "115 114 0:44 / /sys/fs/cgroup fw,nosuid,nodev,noexec,relatime - tmpfs rw" |
|
@jhowardmsft some plans :) we need one more PR merged to full fix |
|
@LK4D4. Thx. I'll do a local revert in the meantime then to validate a different PR. |
|
@jhowardmsft Yup, thanks for your patience. |
Fixes: moby/moby#14543
Fixes: moby/moby#14610
Before this, we got mount info in container:
It has no mount source, so in
parseInfoFilein Docker code,we'll get:
After this fix, we have mount info corrected:
Signed-off-by: Qiang Huang [email protected]