Skip to content

Modernize code #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 24, 2025
Merged

Modernize code #13

merged 4 commits into from
Apr 24, 2025

Conversation

kolyshkin
Copy link
Contributor

Use newer Go features (any, maps, slices, and for range for integers). See individual commits for details.

kolyshkin added 4 commits April 8, 2025 13:55
@kolyshkin
Replace interface{} with any
56a8014 
The keyword any is available since Go 1.18.

Signed-off-by: Kir Kolyshkin <[email protected]>
@kolyshkin
Use slices.Contains
6f76129 
Signed-off-by: Kir Kolyshkin <[email protected]>
@kolyshkin
Use maps.Clone
cfe7b24 
Signed-off-by: Kir Kolyshkin <[email protected]>
@kolyshkin
Use for range with integers
a473597 
This form is available since Go 1.22.

Signed-off-by: Kir Kolyshkin <[email protected]>
@kolyshkin
Copy link
Contributor Author

I need a second review/LGTM here.
@opencontainers/cgroups-maintainers PTAL

@dims @odinuge @haircommander alas you're not opencontainers.org members so can't be included into the above alias. Nevertheless PTAL

thaJeztah
thaJeztah approved these changes Apr 24, 2025
View reviewed changes
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I think there's some linters for this in recent versions of golangci-lint as well

@thaJeztah thaJeztah merged commit 479d74f into opencontainers:main Apr 24, 2025
13 checks passed
@kolyshkin kolyshkin mentioned this pull request Apr 25, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@odinuge odinuge odinuge approved these changes

@thaJeztah thaJeztah thaJeztah approved these changes

@AkihiroSuda AkihiroSuda AkihiroSuda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kolyshkin @odinuge @thaJeztah @AkihiroSuda