Add entity core bookmark #82
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bilalesi
force-pushed
the
add-entity-core-bookmark
branch
from
0a999c3 to
c52b6a5
Compare
bilalesi
commented
Apr 15, 2025
| @@ -215,8 +215,11 @@ class Bookmark(Base): | |||
|
|
|||
| id = Column(UUID(as_uuid=True), primary_key=True, default=uuid.uuid4) | |||
| resource_id = Column(String, nullable=False, index=True) | |||
|
|
|||
| entity_id: Mapped[uuid.UUID | None] = mapped_column( | |||
There was a problem hiding this comment.
this should changed after the migration to not allow Null values
Comment on lines
+21
to
+23
|
|
||
| if category is not None: | ||
| query = query.where(Bookmark.category == category) |
There was a problem hiding this comment.
add the option to filter by category in the getAll endpoint
Comment on lines
+107
to
+111
| @router.post( | ||
| "/{virtual_lab_id}/projects/{project_id}/bookmarks/delete", | ||
| summary="Delete bookmark by category and resource id", | ||
| response_model=LabResponse[None], | ||
| ) | ||
| @verify_vlab_or_project_read |
There was a problem hiding this comment.
this endpoint specific for entity core migration,
pgetta
previously approved these changes
Apr 22, 2025
bilalesi
force-pushed
the
add-entity-core-bookmark
branch
from
c52b6a5 to
41c29f7
Compare
pgetta
approved these changes
May 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
entity-idto the db model and pydantic schemas.