1. Linting of core/serialization.py. 2. ZERO_INDEX and NAME_EQUALS_VALUE coord directories working. 3. Several automatic linting fixes in 4 additional files #173
+47
−194
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
james-isbister
commented
May 20, 2025
james-isbister
commented
- core/serialization.py all linting fixes
- ZERO_INDEX and NAME_EQUALS_VALUE coord directories working
- Remaining automatic linting in simulations.py, circuit_extraction.py, morphology_metrics.py
…LUE coord directories working. 3. Several automatic linting fixes in 4 additional files
chr-pok
reviewed
May 20, 2025
There was a problem hiding this comment.
ZERO_INDEX and VALUE options are working fine (again), thanks for fixing it!
However, I noticed that de-serialization is broken now.
Also, just wondering how to actually access the full paths of the individual instances of the grid scan? I tried grid_scan.coordinate_instances()[0].coordinate_output_root but got PosixPath('.'), not sure if this is intended?
| data = json.load(file) | ||
| return deserialize_obi_object_from_json_data(data) | ||
| def deserialize_obi_object_from_json_file(json_path: Path) -> obi.OBIBaseModel: | ||
| json_dict = json.load(json_path) |
There was a problem hiding this comment.
Deserialization is broken, I think you need to add back the with open ... code:
Suggested change
| json_dict = json.load(json_path) | |
| with open(json_path) as file: | |
| json_dict = json.load(file) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.