Fix --lb-mode=Memory #275
Merged
Fix --lb-mode=Memory #275
+74
−33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WeinaJi
reviewed
May 16, 2025
mgeplf
reviewed
May 19, 2025
mgeplf
reviewed
May 19, 2025
mgeplf
reviewed
May 19, 2025
mgeplf
reviewed
May 19, 2025
juanjosegarcan
force-pushed
the
lb_mode_memory_error
branch
from
d0ed1e0 to
568c6e4
Compare
juanjosegarcan
force-pushed
the
lb_mode_memory_error
branch
from
568c6e4 to
5e96176
Compare
|
we should find a away to not make coveralls mark it as x if we have a ... 0.01% decrease in coverage tho |
cattabiani
reviewed
May 20, 2025
cattabiani
reviewed
May 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
lb-mode Memory is failing when no cell_memory_usage.json or memory_per_metype.json commoning from dry_run are present.
Fix #243
Scope
Add dry_run memory files exists check and throw an error if not informing the user he must dry_run first
Add test for this situation
Testing
Extent tests/unit/test_dry_run.py
Review