Apply workaround in CI for NMODL change #143
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I get the feeling the CI only passes due to NEURON being cached; any way to re-trigger a build without caching? 
|
|
@WeinaJi is this still relevant? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
(Possible) workaround for #3 (i.e. bring back the use of
posix_memaligninstead ofstd::aligned_allocin NMODL, first introduced in BlueBrain/nmodl#933). Note that NMODL is supposed to be integrated at some point in NEURON, so a more permanent fix should become available soon™️ (assuming this one actually works).Scope
Apply a git patch to NMODL when running the CI.
Testing
Re-enable tests that were disabled in #51 due to #3.
Review