-
Notifications
You must be signed in to change notification settings - Fork 0
Circuit detail view [part 1] & fixes on list view #241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
src/components/explore-section/Circuit/ListView/ExploreCircuitTable.tsx
Outdated
Show resolved
Hide resolved
src/components/explore-section/Circuit/ListView/ExploreCircuitTable.tsx
Outdated
Show resolved
Hide resolved
src/components/explore-section/Circuit/ListView/ExploreCircuitTable.tsx
Outdated
Show resolved
Hide resolved
src/components/explore-section/Circuit/content/circuits_tree_formatted.ts
Outdated
Show resolved
Hide resolved
What does it fix? |
I turned all the into to reach the detail view. |
Plesae ensure downloads don't break, that was a pain. |
I won't touch the logic you've done. By the way I use it everywhere else where circuits are used. |
...app/virtual-lab/(free)/explore/(interactive)/interactive/(data)/model/circuit/[key]/page.tsx
Outdated
Show resolved
Hide resolved
src/components/explore-section/Circuit/utils/calculateSubcircuitsForParent.ts
Outdated
Show resolved
Hide resolved
src/components/explore-section/Circuit/utils/findParentCircuitContent.ts
Outdated
Show resolved
Hide resolved
src/components/explore-section/Circuit/content/circuits_flat.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should update the circuit counts on main page and menu to use the map.
Object.keys(map).length
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a lot of work here. Well done!
I have added few comments.
But, I think you forgot to launch npm run lint
before pushing.
If the linter fails locally, it's better to fix the code before the next push.
...app/virtual-lab/(free)/explore/(interactive)/interactive/(data)/model/circuit/[key]/page.tsx
Outdated
Show resolved
Hide resolved
src/components/explore-section/Circuit/DetailView/header/ActionButton.tsx
Show resolved
Hide resolved
src/components/explore-section/Circuit/DetailView/header/Heading.tsx
Outdated
Show resolved
Hide resolved
src/components/explore-section/Circuit/DetailView/header/Heading.tsx
Outdated
Show resolved
Hide resolved
src/components/explore-section/Circuit/DetailView/header/Heading.tsx
Outdated
Show resolved
Hide resolved
src/components/explore-section/Circuit/DetailView/sections/provenance/Literature.tsx
Outdated
Show resolved
Hide resolved
src/components/explore-section/Circuit/DetailView/sections/related-publications/index.tsx
Outdated
Show resolved
Hide resolved
src/components/explore-section/Circuit/DetailView/sections/related-publications/index.tsx
Outdated
Show resolved
Hide resolved
src/components/explore-section/Circuit/ListView/ExploreCircuitTable.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is just a little comment, but all the rest has been fixed, except for the linter that still complains on my machine.
src/components/explore-section/Circuit/DetailView/header/ActionButton.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@loris-olivier-obi, that is terrific. Nice work.
I've left some comments, please see yourself what's relevant.
Detail view