Skip to content

Homepage popup #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 15 commits into
base: develop
Choose a base branch
from
Open

Homepage popup #114

wants to merge 15 commits into from
+95 −24

Conversation

g-bar
Copy link
Contributor

@g-bar g-bar commented Mar 6, 2025 •
edited
Loading

Capture d’écran 2025-03-07 à 11 36 52

@g-bar g-bar changed the title fetch popupdata from sanity Homepage popup Mar 6, 2025
@g-bar g-bar marked this pull request as ready for review March 7, 2025 11:16
@g-bar g-bar requested a review from tolokoban March 7, 2025 11:16
@jdcourcol
Copy link
Contributor

Thanks for implementing it so fast. @g-bar
Unfortunately, after discussing with @gkhazen , I thought a modal would be too intrusive for the end user (and would probably prevent SEO to enter the site).
Georges agreed to have some slide-in notification instead, to drive the user to the registration page. @loris-olivier-obi would you be able to update the mockup w/ that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tolokoban tolokoban Awaiting requested review from tolokoban

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@g-bar @jdcourcol