-
Notifications
You must be signed in to change notification settings - Fork 0
Add noise stimuli in StimulusFactory #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ilkilic
commented
Feb 19, 2025
•
edited
Loading
edited
- adds StepNoise, ShotNoise, and OrnsteinUhlenbeck in StimulusFactory with support for both amplitude-based and threshold-based calculation
- adds threshold-based support for Ramp
- updates the example notebook 5-stimuli to showcase all stimuli
- refactores factory.py
- adds unit-tests
Codecov ReportAttention: Patch coverage is
|
There are some lines in stimulus/factory.py for which codecov complains are not covered tests. Add only if necessary.:). |
@AurelienJaquier Thanks! I have standardised parameter names across all protocols to consistently use standard deviation (sigma) instead of variance:
And I have added pre_delay and post_delay to replace the hardcoded zero delays |
Regarding argument names: I hope you have used the names to same as in neurodamus and sonata-extension. For this comment, I see these type warnings when I "Load diff" for stimulus.py and factory.py: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me!
We decided to unify them in the factory but the the circuit stimulus class uses the same argument names as in Neurodamus And for the Codecov comment, I tried to increase the test coverage as much as possible |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ilkilic ! 🎉 Let's other remaining stimuli from neurodamus in new PRs.