-
Notifications
You must be signed in to change notification settings - Fork 0
Add IV curve plot #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
By the way, would you prefer to actually have one function that computes and plot the IV curve instead of calling two functions? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great!
Yes. If you are making one, a single function for IV (and FI curve if you are making one) would be good. |
I refactored it, let me know if it is fine with you |
Cool. I don't know if you want to add efel as dependency or keep it optional. |
Could you still have two functions? One for running IV responses and one for plotting? We can keep the function doing both, and it could just call the two functions. The more we can subdivide functions, the better. By the way, could you also make the 'compute rmp, compute rin and compute threshold current' one function in tools? That would be useful, since I will also be using that in my notebook |
@darshanmandge I think it would be best not to have efel as a dependency |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Brilliant, thanks a lot!
Adds IV curve plot function as well as helper functions
calculate_max_thresh_current
andcalculate_rheobase
to tools.py for calculating upper bound threshold current and rheobase, respectively.