Skip to content

Add IV curve plot #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jan 16, 2025
Merged

Add IV curve plot #3

merged 8 commits into from
Jan 16, 2025

Conversation

ilkilic
Copy link
Collaborator

@ilkilic ilkilic commented Jan 15, 2025

Adds IV curve plot function as well as helper functions calculate_max_thresh_current and calculate_rheobase to tools.py for calculating upper bound threshold current and rheobase, respectively.

@ilkilic ilkilic self-assigned this Jan 15, 2025
@ilkilic
Copy link
Collaborator Author

ilkilic commented Jan 15, 2025

By the way, would you prefer to actually have one function that computes and plot the IV curve instead of calling two functions?

Copy link
Collaborator

@AurelienJaquier AurelienJaquier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great!

@darshanmandge
Copy link
Collaborator

darshanmandge commented Jan 15, 2025

Yes. If you are making one, a single function for IV (and FI curve if you are making one) would be good.

@ilkilic
Copy link
Collaborator Author

ilkilic commented Jan 15, 2025

By the way, would you prefer to actually have one function that computes and plot the IV curve instead of calling two functions?

I refactored it, let me know if it is fine with you

@darshanmandge
Copy link
Collaborator

Cool. I don't know if you want to add efel as dependency or keep it optional.

@AurelienJaquier
Copy link
Collaborator

Could you still have two functions? One for running IV responses and one for plotting? We can keep the function doing both, and it could just call the two functions. The more we can subdivide functions, the better. By the way, could you also make the 'compute rmp, compute rin and compute threshold current' one function in tools? That would be useful, since I will also be using that in my notebook

@ilkilic
Copy link
Collaborator Author

ilkilic commented Jan 16, 2025

@darshanmandge I think it would be best not to have efel as a dependency

Copy link
Collaborator

@AurelienJaquier AurelienJaquier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Brilliant, thanks a lot!

@ilkilic ilkilic merged commit e09f906 into main Jan 16, 2025
7 checks passed
@ilkilic ilkilic deleted the iv-curve branch January 16, 2025 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants