-
Notifications
You must be signed in to change notification settings - Fork 0
Add Linear stimulus support and update RelativeLinear to enable ramping #10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
🚀 New features to boost your workflow:
|
@@ -259,12 +261,39 @@ def add_replay_hypamp(self, stimulus: Hyperpolarizing): | |||
self.persistent.append(tstim) # type: ignore | |||
return tstim | |||
|
|||
def add_replay_relativelinear(self, stimulus): | |||
def add_replay_linear(self, stimulus: Linear): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could call self.add_ramp() here for less duplication
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! done in the last commit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks nice!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ilkilic.
Later, we should verify if all the stimuli that we code in bluecellulab reproduce the neurodamus stimuli as the implementations look slightly different in neurodamus stimulus_manager.py and stimuli.py. This will be essential for reproducibility of neurodamus network simulation results at the single-cell level using bluecellulab.
amp_end
, making it function as a step instead of a ramp. This update aligns it with Neurodamus by adding support for ramping