Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for moving https://github.com/openaps/openaps to Python3 as the deps are dropping py2 support like hot potatoes.
Significant changes:
long
type, it's all justint
, so BangLong now returns an int without theL
suffix./
now always does float division, while//
does Python2-style integer division. Most of the time this is expected, as there is a float somewhere in the calculation. However, some places I believe an integer is expected:sort_keys=True
to all thejson.dumps
calls, e.g. here'raw_unicode_escape'
to the comparison in several tests