Fix escape key handling in overlays (fixes #1348) #1353
+106
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add isActive: true to useInput hook in all overlay components - Ensures overlays properly capture keyboard input when displayed - Prevents input events from being intercepted by background components - Add comprehensive test suite for help overlay keyboard handling This fixes the issue where the escape key wasn't working to close the help menu. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
|
All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
isActive: truetouseInputhook in all overlay components to ensure proper keyboard event captureChanges
help-overlay.tsx,history-overlay.tsx,diff-overlay.tsx, andmodel-overlay.tsxto addisActive: trueoption to theiruseInputhooksTest Plan
Fixes #1348