Versionrewrite pattern disables sanitize version #390
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrianschroeter
previously approved these changes
Feb 2, 2021
If versionrewrite_pattern is used we assume you know what you are doing. If it is not set we sanitize the version at the end avoid corrupt spec e.g if version hyphens.
M0ses
force-pushed
the
versionrewrite_pattern_disables_sanitize_version
branch
from
e37c77e to
24d0fc5
Compare
|
Works for me. |
I have seen that you adjusted your regex and the issue seems to be done now - sorry for the inconvenience but as already @olafhering pointed out - I would like to avoid an "do what I want" switch in addition. Hopefully this slight regression does not effect to much packages. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.