-
Notifications
You must be signed in to change notification settings - Fork 14
Add content types for NEST Desktop #275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
after discussion with Sebastian Spreizer
}, | ||
"@id": "https://openminds.om-i.org/instances/contentTypes/application_vnd.nest-desktop.model.v4+json", | ||
"@type": "https://openminds.om-i.org/types/ContentType", | ||
"dataType": null, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Associative array then?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mean, yes, because it's a JSON document, but semantically it's a configuration.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there can be more than one data type. let's now not integrate this, but I'd like this field being filled for all content types in the long run
}, | ||
"@id": "https://openminds.om-i.org/instances/contentTypes/application_vnd.nest-desktop.model.v4+json", | ||
"@type": "https://openminds.om-i.org/types/ContentType", | ||
"dataType": null, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Associative array?
instances/latest/contentTypes/application_vnd.nest-desktop.model.v4+json.jsonld
Outdated
Show resolved
Hide resolved
"fileExtension": [ | ||
".json" | ||
], | ||
"name": "application/vnd.nest-desktop.model.v4+json", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should the version not come before ?
vnd.nest-desktop.v4.model+json
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought about that, but v4 of a format specification doesn't necessarily correspond to v4 of the software (in this case it does, but as a general rule I think the version spec should come at the end (just before any "+" modifiers)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okay. we may revisit the existing content types. I don't think this was done consistently as you suggested (but I'm totally okay with that suggestion)
instances/latest/contentTypes/application_vnd.nest-desktop.model.v4+json.jsonld
Outdated
Show resolved
Hide resolved
instances/latest/contentTypes/application_vnd.nest-desktop.project.v4+json.jsonld
Outdated
Show resolved
Hide resolved
instances/latest/contentTypes/application_vnd.nest-desktop.model.v4+json.jsonld
Outdated
Show resolved
Hide resolved
…nd.nest-desktop.model.v4+json.jsonld Co-authored-by: Lyuba Zehl <[email protected]>
ready to merge, I think |
after discussion with Sebastian Spreizer