Skip to content

Add content types for NEST Desktop #275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Conversation

apdavison
Copy link
Member

after discussion with Sebastian Spreizer

after discussion with Sebastian Spreizer
@apdavison apdavison requested a review from lzehl March 13, 2025 15:50
},
"@id": "https://openminds.om-i.org/instances/contentTypes/application_vnd.nest-desktop.model.v4+json",
"@type": "https://openminds.om-i.org/types/ContentType",
"dataType": null,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Associative array then?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean, yes, because it's a JSON document, but semantically it's a configuration.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there can be more than one data type. let's now not integrate this, but I'd like this field being filled for all content types in the long run

},
"@id": "https://openminds.om-i.org/instances/contentTypes/application_vnd.nest-desktop.model.v4+json",
"@type": "https://openminds.om-i.org/types/ContentType",
"dataType": null,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Associative array?

"fileExtension": [
".json"
],
"name": "application/vnd.nest-desktop.model.v4+json",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the version not come before ?
vnd.nest-desktop.v4.model+json

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought about that, but v4 of a format specification doesn't necessarily correspond to v4 of the software (in this case it does, but as a general rule I think the version spec should come at the end (just before any "+" modifiers)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay. we may revisit the existing content types. I don't think this was done consistently as you suggested (but I'm totally okay with that suggestion)

@apdavison apdavison added the ContentType ContentType instances - addition of new or update of existing ones label Mar 14, 2025
…nd.nest-desktop.model.v4+json.jsonld

Co-authored-by: Lyuba Zehl <[email protected]>
@apdavison
Copy link
Member Author

ready to merge, I think

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ContentType ContentType instances - addition of new or update of existing ones
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants