feat: support write method #26
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hiiiik
force-pushed
the
write
branch
5 times, most recently
from
be286f5 to
3ed3377
Compare
hezhangjian
reviewed
Aug 11, 2024
| std::string LineProtocolEncoder::Encode(const std::vector<Point>& points) | ||
| { | ||
| if (points.empty()) { | ||
| throw Exception(errc::LogicErrors::InvalidArgument, |
There was a problem hiding this comment.
This should be sync with other languages
There was a problem hiding this comment.
Now we allow user to pass an empty vector of points that the library will neither throw an exception nor invoke any request to server for it.
hezhangjian
reviewed
Aug 11, 2024
| } | ||
| else if constexpr (std::is_same_v<T, double>) { | ||
| Append(innerValue); | ||
| } |
There was a problem hiding this comment.
shoud we add a default error? like
else {
static_assert(always_false<T>::value, "Unhandled type in std::variant.");
}There was a problem hiding this comment.
Good advice, I will add a runtime checking in the else branch.
Signed-off-by: ik <[email protected]>
hezhangjian
approved these changes
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.