Dockerized It #21
Closed
Dockerized It #21
+151
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjbck
requested changes
Apr 2, 2025
|
|
||
| set -e # Exit immediately if a command exits with a non-zero status | ||
|
|
||
| DIR="/servers" |
There was a problem hiding this comment.
We should leave this as an optional env var and set the default as an empty string
| echo "$DIR is empty" | ||
| fi | ||
|
|
||
| if ! [ -f "/app/config.json" ]; then |
There was a problem hiding this comment.
it should raise an exception instead of using example.config.json
| - "8080:8000" | ||
| volumes: | ||
| - ./app:/app | ||
| - ./servers:/servers |
| @@ -48,6 +49,30 @@ uvx mcpo --port 8000 -- uvx mcp-server-time --local-timezone=America/New_York | |||
|
|
|||
| That’s it. Your MCP tool is now available at http://localhost:8000 with a generated OpenAPI schema — test it live at [http://localhost:8000/docs](http://localhost:8000/docs). | |||
|
|
|||
| ## 🐋 Docker | |||
|
|
|||
| mcpo can be run in Docker with the enclosed dockerfile. Mount a volume containing config.json to /app and add custom (offline/source) servers to /servers. | |||
|
Just in case it is useful, I made an unofficial Docker image distribution here: https://github.com/dtinth/mcpo-docker/blob/main/Dockerfile It's very unoptimized but it has:
Feel free to yoink code from it. 😃 |
gaby
reviewed
Apr 3, 2025
|
Would be useful to have a GitHub workflow to publish the image too. But this is a great start |
MrZoidberg
reviewed
Apr 6, 2025
| COPY . /app | ||
|
|
||
| # Install mcpo from source | ||
| RUN pip install . |
There was a problem hiding this comment.
better to run this after apt-get since apt-get would be cached all the time, and only the next layers will be re-built.
|
Closing in favour of 45c474e |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-did the dockerization using the uv build of python bookworm slim, then added npx and curl which fixed all the issues I was having of using hosted tools.
Entrypoint.sh still automatically installs python tools added to /servers dir but no longer requires offline servers in order to run.
Also added environment variables for uvicorn port and log level.