Define conversion of prometheus native histograms to OpenTelemetry exponential histograms #4561
+32
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dashpole
force-pushed
the
native_histograms
branch
from
1a3a046 to
9eb6672
Compare
3 tasks
krajorama
reviewed
Jun 25, 2025
…ponential histograms
Co-authored-by: George Krajcsovits <[email protected]>
dashpole
force-pushed
the
native_histograms
branch
from
5ac176e to
bd56bea
Compare
Co-authored-by: George Krajcsovits <[email protected]>
Signed-off-by: Arthur Silva Sens <[email protected]>
Schemas outside of range are dropped
dashpole
commented
Jul 7, 2025
dashpole
commented
Jul 7, 2025
| - `StartTimeUnixNano` is set to the `Created` timestamp, if available. | ||
| - `AggregationTemporality` is set to `cumulative`. | ||
|
|
||
| Native histograms of the float or gauge flavors MUST be dropped. Native Histograms with `Schema` outside of the range [-4, 8] MUST be dropped. |
There was a problem hiding this comment.
I noticed in the NHCB PR that the PRW 2.0 receiver accepts float histograms, but rounds down floats to the nearest integer. This language here differs from that implementation. Do we want to specify that float histograms should be rounded down to the nearest integer instead?
There was a problem hiding this comment.
IMO, OTel should add these concepts, and to drop them is appropriate.
jmacd
approved these changes
Jul 8, 2025
| - `StartTimeUnixNano` is set to the `Created` timestamp, if available. | ||
| - `AggregationTemporality` is set to `cumulative`. | ||
|
|
||
| Native histograms of the float or gauge flavors MUST be dropped. Native Histograms with `Schema` outside of the range [-4, 8] MUST be dropped. |
There was a problem hiding this comment.
IMO, OTel should add these concepts, and to drop them is appropriate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #4494
Changes
This conversion is the inverse of the exp -> native conversion defined here: https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/compatibility/prometheus_and_openmetrics.md#exponential-histograms.
CHANGELOG.mdfile updated for non-trivial changes@open-telemetry/prometheus-interoperability @ywwg @krajorama