matrix: add built-in span processor's decorator requirement #3189
Conversation
| @@ -82,6 +82,7 @@ formats is required. Implementing more than one format is optional. | |||
| | [IdGenerators](specification/trace/sdk.md#id-generators) | | + | + | | + | + | + | + | + | + | | + | | |||
| | [SpanLimits](specification/trace/sdk.md#span-limits) | X | + | + | | + | + | + | + | | - | | + | | |||
| | [Built-in `SpanProcessor`s implement `ForceFlush` spec](specification/trace/sdk.md#forceflush-1) | | | + | | + | + | + | + | + | + | + | | | |||
| | [Built-in `SpanProcessor`s implement decorators](specification/trace/sdk.md#span-processor) | | | | | | | | | | | | | | |||
There was a problem hiding this comment.
I'm confused by what a decorator is. Seems like this needs to be clarified first before adding it to the matrix.
There was a problem hiding this comment.
If I understood the conversation in slack correctly, this pull request is just a catalyst for exactly that
There was a problem hiding this comment.
Right. I figure this will bring it to the attention of some who don't know about it already and then discussion can be had here and then in the SIG meeting on Tuesday. That should at least start the process of clarifying what they are so another PR can be made to improve the spec.
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
|
This does not seem to have had the intended effect |
|
Yea. There didn't seem to be appetite for actually having this be part of the spec, despite it already being part of the spec :). I was going to make an alternative PR to remove it entirely from the spec and see what happens with that, but I suspect the same result. There will need to be a concerted effort to push forward a proposal to replace "decorators" I think. I'd propose a WG to happen now but don't think the TC has the resources to sponsor another one at this time. |
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
|
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
Changes
Updates
spec-compliance-matrix.mdfor the requirement of being able to "decorate" the built-in Span Processors: