-
Notifications
You must be signed in to change notification settings - Fork 717
Logging API accepts optional Context at LogRecord init else get_current; deprecates trace_id, span_id, trace_flags #4597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
xrmx
merged 28 commits into
open-telemetry:main
from
tammy-baylis-swi:logs-api-accept-otel-context
Jun 17, 2025
Merged
Logging API accepts optional Context at LogRecord init else get_current; deprecates trace_id, span_id, trace_flags #4597
xrmx
merged 28 commits into
open-telemetry:main
from
tammy-baylis-swi:logs-api-accept-otel-context
Jun 17, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aabmass
reviewed
May 29, 2025
opentelemetry-sdk/src/opentelemetry/sdk/_logs/_internal/__init__.py
Outdated
Show resolved
Hide resolved
aabmass
approved these changes
Jun 4, 2025
opentelemetry-sdk/src/opentelemetry/sdk/_logs/_internal/__init__.py
Outdated
Show resolved
Hide resolved
aabmass
approved these changes
Jun 5, 2025
opentelemetry-sdk/src/opentelemetry/sdk/_logs/_internal/__init__.py
Outdated
Show resolved
Hide resolved
Let's get one more approval and merge |
emdneto
reviewed
Jun 10, 2025
opentelemetry-sdk/src/opentelemetry/sdk/_logs/_internal/__init__.py
Outdated
Show resolved
Hide resolved
emdneto
reviewed
Jun 12, 2025
xrmx
reviewed
Jun 13, 2025
xrmx
approved these changes
Jun 16, 2025
emdneto
approved these changes
Jun 17, 2025
This was referenced Jun 19, 2025
1 task
7 tasks
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Context
at LogRecord init. If not provided, current context is used.Adds order-of-precedence so that, if provided Context includes a valid current span, its span information will be used instead of anyDeprecates old LogRecord init and logs a warning (eb28a8d)trace_id
,span_id
,trace_flags
provided at init.LogRecord'sRemoved in 73e7b39 as discussed with Python SIG.to_json
does a serialization of what it can in Context (e.g. string, int) then casts to string for other values (e.g. Span).LoggingHandler'sLogging SDK (LogRecord init) defaults to current context in 676d9ff, as discussed with Python SIG._translate
inits LogRecord with current context.Let me know if too many changes for one PR and I can break it up or remove anything out of scope.
Fixes #4328
Replaces #4584
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Does This PR Require a Contrib Repo Change?
Checklist: