Allows API packages to specify file-based and env-based config #1621
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
| use function interface_exists; | ||
|
|
||
| interface_exists(ComponentPlugin::class); |
There was a problem hiding this comment.
Interesting 👀
Generally curious as I have not seen this before: does this differ in some way to extending OpenTelemetry\API\Configuration\Config\ComponentPlugin on this interface?
There was a problem hiding this comment.
Extending would lead to BC breaks, for example we cannot narrow the type of ComponentProvider::getConfig() $registry from API ComponentProviderRegistry to SDK ComponentProviderRegistry.
|
Should I base #1523 on the back of this, given the environment changes here? 🤔 (I appreciate that my PR is a little stale, but I plan to pick it up again in future) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves
ComponentProviderand related classes to API and adds env-based loader to allow API packages (instrumentations and propagators) to specify their configuration options.