Skip to content

Ignore TypeError in ::serializeToJsonString() if google/protobuf ^4.31 and ext-protobuf <4.31 are installed #1598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Nevay
Copy link
Contributor

@Nevay Nevay commented May 16, 2025

Resolves #1597 by ignoring the TypeError; could alternatively check for installed extension version but this fix seems simpler.

@Nevay Nevay requested a review from a team as a code owner May 16, 2025 22:52
Copy link

codecov bot commented May 16, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 69.29%. Comparing base (389fa3f) to head (1efed68).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/Contrib/Otlp/ProtobufSerializer.php 0.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1598      +/-   ##
============================================
- Coverage     69.46%   69.29%   -0.18%     
- Complexity     2804     2805       +1     
============================================
  Files           414      414              
  Lines          8584     8585       +1     
============================================
- Hits           5963     5949      -14     
- Misses         2621     2636      +15     
Flag Coverage Δ
8.1 69.06% <0.00%> (-0.02%) ⬇️
8.2 69.24% <0.00%> (-0.03%) ⬇️
8.3 69.24% <0.00%> (-0.15%) ⬇️
8.4 69.24% <0.00%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/Contrib/Otlp/ProtobufSerializer.php 19.04% <0.00%> (-0.31%) ⬇️

... and 6 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 389fa3f...1efed68. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@brettmc brettmc merged commit 2fcafab into open-telemetry:main May 17, 2025
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Google\\Protobuf\\Internal\\Message::serializeToJsonString(): Argument #1 must be of type bool, int given
2 participants