Skip to content

adding otlp/file exporter #1465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 8, 2025
Merged

Conversation

brettmc
Copy link
Collaborator

@brettmc brettmc commented Jan 6, 2025

the spec has added in-development otlp file/stdout exporter. We already supported this programmatically, so add some factories and sdk config to allow configuration from environment (only for stdout, per spec)

See https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/protocol/file-exporter.md

Closes: #1457

the spec has added in-development otlp file/stdout exporter. We already supported this programmatically, so
add some factories and sdk config to allow configuration from environment (only for stdout, per spec)
@brettmc brettmc requested a review from a team as a code owner January 6, 2025 04:40
Copy link

codecov bot commented Jan 6, 2025

Codecov Report

Attention: Patch coverage is 0% with 12 lines in your changes missing coverage. Please review.

Project coverage is 73.23%. Comparing base (b515b6b) to head (af7ecf5).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
src/Contrib/Otlp/StdoutLogsExporterFactory.php 0.00% 3 Missing ⚠️
src/Contrib/Otlp/StdoutMetricExporterFactory.php 0.00% 3 Missing ⚠️
src/Contrib/Otlp/StdoutSpanExporterFactory.php 0.00% 3 Missing ⚠️
src/Contrib/Otlp/_register.php 0.00% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1465      +/-   ##
============================================
- Coverage     73.27%   73.23%   -0.04%     
- Complexity     2683     2686       +3     
============================================
  Files           387      390       +3     
  Lines          8014     8026      +12     
============================================
+ Hits           5872     5878       +6     
- Misses         2142     2148       +6     
Flag Coverage Δ
8.1 72.87% <0.00%> (-0.11%) ⬇️
8.2 73.09% <0.00%> (-0.10%) ⬇️
8.3 73.10% <0.00%> (-0.08%) ⬇️
8.4 73.22% <0.00%> (+<0.01%) ⬆️
8.5 73.08% <0.00%> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/Contrib/Otlp/StdoutLogsExporterFactory.php 0.00% <0.00%> (ø)
src/Contrib/Otlp/StdoutMetricExporterFactory.php 0.00% <0.00%> (ø)
src/Contrib/Otlp/StdoutSpanExporterFactory.php 0.00% <0.00%> (ø)
src/Contrib/Otlp/_register.php 0.00% <0.00%> (ø)

... and 5 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b515b6b...af7ecf5. Read the comment docs.

Copy link
Contributor

@ChrisLightfootWild ChrisLightfootWild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor linting for now or later, otherwise, looks good!

@brettmc brettmc merged commit 32e301e into open-telemetry:main Jan 8, 2025
10 of 11 checks passed
@brettmc brettmc deleted the otlp-file-exporter branch January 8, 2025 23:50
brettmc added a commit to brettmc/opentelemetry-php that referenced this pull request Jan 9, 2025
the spec has added in-development otlp file/stdout exporter. We already supported this programmatically, so
add some factories and sdk config to allow configuration from environment (only for stdout, per spec)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

implement otlp file/stdout exporter
3 participants