optimize resource creation #1210
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- instead of creating new resources from various factories, create them once from sdk autoloader and pass them to the factories (most of which already supported this). - check env before php.ini for config, since this is the more popular approach and saves some cycles - cache header from OtlpUtil, to save a couple of calls to Sdk detector
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1210 +/- ##
============================================
- Coverage 84.08% 83.22% -0.86%
- Complexity 2237 2251 +14
============================================
Files 285 285
Lines 6359 6409 +50
============================================
- Hits 5347 5334 -13
- Misses 1012 1075 +63
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 13 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
bobstrecansky
approved these changes
Jan 12, 2024
| @@ -62,6 +62,7 @@ public function serialize(): string | |||
| * resource, the value of the updating resource MUST be picked (even if the updated value is empty) | |||
| * | |||
| * @see https://github.com/open-telemetry/opentelemetry-specification/blob/v1.20.0/specification/resource/sdk.md#merge | |||
| * @todo can we optimize this to avoid re-validating the attributes on merge? | |||
There was a problem hiding this comment.
Created an issue for this: #1212
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Profiling the SDK autoloader startup with xdebug, I could see that we re-detect resources multiple times which adds overhead.
pass them to the factories (most of which already supported this).