Skip to content

chore: add prometheus example #560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

dyladan
Copy link
Member

@dyladan dyladan commented Nov 21, 2019

Which problem is this PR solving?

Short description of the changes

  • Add prometheus metrics example

@codecov-io
Copy link

codecov-io commented Nov 21, 2019

Codecov Report

Merging #560 into master will increase coverage by 0.34%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #560      +/-   ##
==========================================
+ Coverage   92.28%   92.63%   +0.34%     
==========================================
  Files         151      152       +1     
  Lines        7313     7740     +427     
  Branches      641      666      +25     
==========================================
+ Hits         6749     7170     +421     
- Misses        564      570       +6
Impacted Files Coverage Δ
...opentelemetry-core/src/platform/node/timer-util.ts 33.33% <0%> (-16.67%) ⬇️
.../opentelemetry-plugin-redis/test/assertionUtils.ts 95.83% <0%> (-4.17%) ⬇️
...es/opentelemetry-node/src/instrumentation/utils.ts 96% <0%> (-4%) ⬇️
...res/opentelemetry-plugin-pg/test/assertionUtils.ts 96.29% <0%> (-3.71%) ⬇️
...ges/opentelemetry-core/src/common/ConsoleLogger.ts 91.66% <0%> (-3.08%) ⬇️
...ckages/opentelemetry-core/src/common/NoopLogger.ts 57.14% <0%> (-2.86%) ⬇️
...telemetry-core/src/context/propagation/B3Format.ts 96.15% <0%> (-1.29%) ⬇️
...entelemetry-exporter-jaeger/test/transform.test.ts 100% <0%> (ø) ⬆️
...entelemetry-core/test/common/ConsoleLogger.test.ts 100% <0%> (ø) ⬆️
...opentelemetry-base/test/resources/resource.test.ts 100% <0%> (ø) ⬆️
... and 31 more

@dyladan
Copy link
Member Author

dyladan commented Nov 21, 2019

@mayurkale22 thanks for the suggestions. Can't believe I missed that.

@dyladan
Copy link
Member Author

dyladan commented Nov 25, 2019

The failing test is lint & docs saying https://github.com/open-telemetry/opentelemetry-js is a 500 link. I think GitHub may be having issues.

@mayurkale22
Copy link
Member

The failing test is lint & docs saying https://github.com/open-telemetry/opentelemetry-js is a 500 link. I think GitHub may be having issues.

Just restarted the workflow, hopefully that will solve the problem.

@mayurkale22 mayurkale22 merged commit bbc424d into open-telemetry:master Nov 25, 2019
@dyladan dyladan deleted the prometheus-example branch November 25, 2019 22:13
pichlermarc pushed a commit to dynatrace-oss-contrib/opentelemetry-js that referenced this pull request Dec 15, 2023
* chore: 0.23.0 release proposal

* chore: changelog

Co-authored-by: obecny <[email protected]>
Co-authored-by: Daniel Dyla <[email protected]>
martinkuba pushed a commit to martinkuba/opentelemetry-js that referenced this pull request Mar 13, 2024
* chore: 0.23.0 release proposal

* chore: changelog

Co-authored-by: obecny <[email protected]>
Co-authored-by: Daniel Dyla <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants