Skip to content

chore: upgrade to typescript-eslint v8 #5478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

loganrosen
Copy link
Contributor

Which problem is this PR solving?

The repository currently depends on an old version of typescript-eslint (v5).

Short description of the changes

Upgrading to typescript-eslint v8 to pick up the latest recommended lint rules and modifying the code to be compliant with the new rules. In most cases, this required updating/adding new ignores for renamed/new rules. In other cases, non-breaking changes were made to the code to make it compliant. I also upgraded eslint to the last v8 version due to a new stricter peer dependency requirement.

How Has This Been Tested?

npm run lint and npm run test succeed.

@loganrosen loganrosen requested a review from a team as a code owner February 15, 2025 05:00
Copy link

linux-foundation-easycla bot commented Feb 15, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

Copy link

codecov bot commented Feb 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.95%. Comparing base (8e50498) to head (8281a76).
Report is 62 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5478   +/-   ##
=======================================
  Coverage   94.95%   94.95%           
=======================================
  Files         308      308           
  Lines        7928     7933    +5     
  Branches     1604     1608    +4     
=======================================
+ Hits         7528     7533    +5     
  Misses        400      400           
Files with missing lines Coverage Δ
api/src/diag/ComponentLogger.ts 95.00% <100.00%> (ø)
api/src/propagation/TextMapPropagator.ts 14.28% <ø> (ø)
api/src/trace/NoopTracer.ts 97.67% <100.00%> (+0.23%) ⬆️
...ntelemetry-instrumentation-grpc/src/serverUtils.ts 90.66% <ø> (ø)
...ental/packages/opentelemetry-sdk-node/src/utils.ts 92.03% <ø> (ø)
...r-base/src/bounded-queue-export-promise-handler.ts 100.00% <100.00%> (ø)
...-base/src/configuration/otlp-http-configuration.ts 100.00% <ø> (ø)
...rter-base/src/transport/http-exporter-transport.ts 94.44% <ø> (ø)
...-grpc-exporter-base/src/grpc-exporter-transport.ts 100.00% <ø> (ø)
...kages/opentelemetry-core/src/utils/lodash.merge.ts 60.86% <ø> (ø)
... and 8 more
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

github-actions bot commented May 5, 2025

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days.

@github-actions github-actions bot added the stale label May 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant