Skip to content

Remove yurishkuro as approver #547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 19, 2019
Merged

Remove yurishkuro as approver #547

merged 2 commits into from
Nov 19, 2019

Conversation

yurishkuro
Copy link
Member

I haven't been following this project due to other commitments.

I haven't been following this project closely.
@codecov-io
Copy link

codecov-io commented Nov 18, 2019

Codecov Report

Merging #547 into master will decrease coverage by 2.29%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master     #547     +/-   ##
=========================================
- Coverage   92.49%   90.19%   -2.3%     
=========================================
  Files         145      143      -2     
  Lines        7153     7151      -2     
  Branches      624      647     +23     
=========================================
- Hits         6616     6450    -166     
- Misses        537      701    +164
Impacted Files Coverage Δ
...pentelemetry-core/test/internal/validators.test.ts 50% <0%> (-50%) ⬇️
...elemetry-core/test/trace/spancontext-utils.test.ts 55.55% <0%> (-44.45%) ⬇️
...lemetry-core/test/trace/ProbabilitySampler.test.ts 56.52% <0%> (-43.48%) ⬇️
...s/opentelemetry-core/test/trace/NoopTracer.test.ts 60% <0%> (-40%) ⬇️
...s/opentelemetry-core/test/context/B3Format.test.ts 63.39% <0%> (-36.61%) ⬇️
...ges/opentelemetry-core/test/trace/NoopSpan.test.ts 63.63% <0%> (-36.37%) ⬇️
...s/opentelemetry-core/test/trace/tracestate.test.ts 65.06% <0%> (-34.94%) ⬇️
...ntelemetry-core/test/trace/NoRecordingSpan.test.ts 71.42% <0%> (-28.58%) ⬇️
...ackages/opentelemetry-core/src/platform/node/id.ts 71.42% <0%> (-28.58%) ⬇️
...ages/opentelemetry-plugin-http/test/utils/utils.ts 33.33% <0%> (-26.67%) ⬇️
... and 28 more

@bogdandrutu
Copy link
Member

I think you need to remove the user from the CODEOWNERS as well.

@yurishkuro
Copy link
Member Author

I'm not in CODEOWNERS

@yurishkuro yurishkuro merged commit 724f9cc into master Nov 19, 2019
@yurishkuro yurishkuro deleted the yurishkuro-patch-1 branch November 19, 2019 05:20
pichlermarc pushed a commit to dynatrace-oss-contrib/opentelemetry-js that referenced this pull request Dec 15, 2023
* chore: 0.22.0 release proposal

* chore: changelog

Co-authored-by: dyladan <[email protected]>
martinkuba pushed a commit to martinkuba/opentelemetry-js that referenced this pull request Mar 13, 2024
* chore: 0.22.0 release proposal

* chore: changelog

Co-authored-by: dyladan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants