feat: Add prometheus exporter #483
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dyladan
requested review from
bg451,
danielkhan,
markwolff,
mayurkale22,
OlivierAlbertini,
rochdev and
vmarchaud
as code owners
danielkhan
approved these changes
Nov 4, 2019
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #483 +/- ##
==========================================
+ Coverage 92.03% 92.60% +0.57%
==========================================
Files 138 145 +7
Lines 6264 7114 +850
Branches 527 626 +99
==========================================
+ Hits 5765 6588 +823
- Misses 499 526 +27
🚀 New features to boost your workflow:
|
mayurkale22
reviewed
Nov 4, 2019
…s-contrib/opentelemetry-js into add-prometheus-exporter-dan
mayurkale22
reviewed
Nov 5, 2019
Co-Authored-By: Mayur Kale <[email protected]>
mayurkale22
reviewed
Nov 5, 2019
…s-contrib/opentelemetry-js into add-prometheus-exporter-dan
mayurkale22
approved these changes
Nov 5, 2019
There was a problem hiding this comment.
Thank you @dyladan for this PR and for addressing my feedback! LGTM!
bg451
approved these changes
Nov 6, 2019
draffensperger
approved these changes
Nov 6, 2019
| * @param name name to be sanitized | ||
| */ | ||
| private _sanitizePrometheusMetricName(name: string): string { | ||
| return name.replace(this._invalidCharacterRegex, '_'); // replace all invalid characters with '_' |
There was a problem hiding this comment.
Is it possible this could cause duplicates? Should we write a warning in that case (could be a follow up task)?
There was a problem hiding this comment.
We could replace period with __DOT__ or similar
|
I managed to run the end to end example using prometheus exporter, looks like everything is working fine. I tried creating and updating simple
|
6 tasks
pichlermarc
pushed a commit
to dynatrace-oss-contrib/opentelemetry-js
that referenced
this pull request
Dec 15, 2023
pichlermarc
pushed a commit
to dynatrace-oss-contrib/opentelemetry-js
that referenced
this pull request
Dec 15, 2023
* feat: add responseHook config to redis instrumentation * fix: lint fix * feat: add responseHook config to redis instrumentation * fix: lint fix * chore(deps): update all non-major dependencies (open-telemetry#483) * chore: generalize the instrumentation file name (open-telemetry#479) * feat: add responseHook config to graphql instrumentation * Apply suggestions from code review Co-authored-by: Bartlomiej Obecny <[email protected]> * test: add a test for a responseHook that isn't a function * fix: lint fix Co-authored-by: WhiteSource Renovate <[email protected]> Co-authored-by: Rauno Viskus <[email protected]> Co-authored-by: Bartlomiej Obecny <[email protected]>
martinkuba
pushed a commit
to martinkuba/opentelemetry-js
that referenced
this pull request
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
With #482 this now provides an end-to-end metrics story
Short description of the changes
Adds a metrics exporter for the prometheus backend. In its current state, the exporter maintains an internal state with the values of all exported metrics, which is then returned when an endpoint is called by Prometheus.