Skip to content

docs(instrumentation-http): remove semconv key column from readme #4754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

JamieDanielson
Copy link
Member

Which problem is this PR solving?

We decided the key column was redundant and unnecessary. My original PR added the whole table #4587 before we decided on this.

Short description of the changes

  • remove key column from README in instrumentation-http

Type of change

  • This change requires a documentation update

How Has This Been Tested?

n/a

Checklist:

  • Followed the style guidelines of this project
  • Unit tests have been added
  • Documentation has been updated

@JamieDanielson JamieDanielson requested a review from a team June 3, 2024 19:54
@JamieDanielson JamieDanielson changed the title docs(instrumentation-http): cleanup readme semconv keys docs(instrumentation-http): remove semconv key column from readme Jun 3, 2024
@pichlermarc pichlermarc added this pull request to the merge queue Jun 4, 2024
Merged via the queue into open-telemetry:main with commit 1ef6027 Jun 4, 2024
19 of 20 checks passed
@JamieDanielson JamieDanielson deleted the jamie.cleanup-readme-from-semconv-update branch June 4, 2024 14:24
Zirak pushed a commit to Zirak/opentelemetry-js that referenced this pull request Sep 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants