test(exporter-*-grpc): use RegExp to match Deadline Exceeded error #4620
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trentm
approved these changes
Apr 10, 2024
There was a problem hiding this comment.
LGTM
FWIW, I think the relevant grpc-js change was: grpc/grpc-node@d7d1717#diff-a2981769852ae1a4aa124162b4180aa93f74f0e999aa382b8efc524f6a083441R118
| @@ -10,6 +10,7 @@ | |||
| "hasInstallScript": true, | |||
| "license": "Apache-2.0", | |||
| "workspaces": [ | |||
| "api", | |||
There was a problem hiding this comment.
Opened #4623 to fix this 🙂
dyladan
approved these changes
Apr 10, 2024
Thanks for digging that one up 🙂 It's good to have a reference 👍 |
legalimpurity
pushed a commit
to legalimpurity/opentelemetry-js
that referenced
this pull request
Apr 26, 2024
Zirak
pushed a commit
to Zirak/opentelemetry-js
that referenced
this pull request
Sep 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
New versions of
@grpc/grpc-jsadd more info to theDeadline Exceedederror, making our tests fail. The error still starts withDeadline Exceededso I switched the assertion from astrictEqual()to amatch()Short description of the changes
@grpc/grpc-jsto latest (package-lock.json only)How Has This Been Tested?