Skip to content

chore(examples): lint examples/koa using shared top-level eslint config #2903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 27, 2025

Conversation

trentm
Copy link
Contributor

@trentm trentm commented Jun 26, 2025

Refs: #2891

@trentm trentm self-assigned this Jun 26, 2025
@trentm trentm requested a review from a team as a code owner June 26, 2025 18:08
Copy link

codecov bot commented Jun 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.81%. Comparing base (196b7a1) to head (b257485).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2903      +/-   ##
==========================================
+ Coverage   89.76%   89.81%   +0.04%     
==========================================
  Files         187      187              
  Lines        9149     9149              
  Branches     1885     1885              
==========================================
+ Hits         8213     8217       +4     
+ Misses        936      932       -4     

see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

import { default as axios } from 'axios';
import * as axios from 'axios';
// eslint-disable-next-line import/extensions
import { setupTracing } from './tracer';
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI: This need to eslint-disable-next-line import/extensions will be dropped once all examples/ packages are using the top-level eslint.config.js and we can delete examples/.eslintrc. It is the "extends": "airbnb-base", in "examples/.eslintrc" that is making this necessary for now.

(The alternative is to delete "examples/.eslintrc" and possibly break npm run lint:examples in the top-level until I complete all the items in #2891)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you have an issue to track dropping the comments (on this and any other PR that you had to add it) or can you update the issue 2891 to include that as a step?

@trentm trentm merged commit 5f1b79e into open-telemetry:main Jun 27, 2025
20 checks passed
@trentm trentm deleted the trentm-lint-examples-koa branch June 27, 2025 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants