Skip to content

test(instrumentation-aws-sdk): update client in bedrock-runtime tests to use NodeHttpHandler instead of the new default NodeHttp2Handler #2810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 2, 2025

Conversation

jj22ee
Copy link
Contributor

@jj22ee jj22ee commented May 1, 2025

Which problem is this PR solving?

Short description of the changes

  • manually configure the Bedrock Runtime client to use NodeHttpHandler (instead of the new default NodeHttp2Handler) in tests so Nock will work, similarly to what is done for Kinesis client test.

Testing

Locally changed the devDependencies for aws sdk instrumentation to use "@aws-sdk/client-bedrock-runtime": "3.798.0", then ran the tests which succeeded.

… to use NodeHttpHandler instead of the new default NodeHttp2Handler
Copy link

codecov bot commented May 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.51%. Comparing base (b3a70d7) to head (ca5bf0b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2810      +/-   ##
==========================================
+ Coverage   89.46%   89.51%   +0.04%     
==========================================
  Files         180      180              
  Lines        8735     8735              
  Branches     1778     1778              
==========================================
+ Hits         7815     7819       +4     
+ Misses        920      916       -4     

see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jj22ee
Copy link
Contributor Author

jj22ee commented May 1, 2025

@trentm @pichlermarc

@trentm trentm enabled auto-merge (squash) May 2, 2025 15:08
@trentm trentm merged commit 7c16951 into open-telemetry:main May 2, 2025
8 checks passed
@trentm
Copy link
Contributor

trentm commented May 2, 2025

Thanks!

@trentm trentm linked an issue May 2, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[instrumentation-aws-sdk] TAV failing for bedrock v3.798.0
4 participants