Skip to content

chore: update nx.json for better caching #2783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 10, 2025

Conversation

david-luna
Copy link
Contributor

Which problem is this PR solving?

Fixes nx.json configuration for caching. The input globs need to have the recursive lookup for typescript files **/*.ts otherwise it will compile only once from the root folder even if you do changes in a package later.

The issue impacts only locally and not in the CI.

Short description of the changes

  • modify the glob patter in nx.json inputs

@david-luna david-luna requested a review from a team as a code owner April 10, 2025 13:47
Copy link

codecov bot commented Apr 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.45%. Comparing base (122b203) to head (4a78022).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2783   +/-   ##
=======================================
  Coverage   89.45%   89.45%           
=======================================
  Files         174      174           
  Lines        8318     8318           
  Branches     1591     1591           
=======================================
  Hits         7441     7441           
  Misses        877      877           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@pichlermarc pichlermarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@pichlermarc pichlermarc merged commit b6d6d94 into open-telemetry:main Apr 10, 2025
20 checks passed
@david-luna david-luna deleted the nx-cache-tuning branch April 15, 2025 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants