fix(instrumentation-pg): connection string parsing #2715
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…trib into fix-connection-string-in-pool
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2715 +/- ##
=======================================
Coverage 92.41% 92.42%
=======================================
Files 171 171
Lines 8150 8169 +19
Branches 1653 1660 +7
=======================================
+ Hits 7532 7550 +18
- Misses 618 619 +1
|
|
hey @maryliag! can I please get a review on this PR? |
|
@nikmel2803 linter fails |
maryliag
reviewed
Feb 19, 2025
There was a problem hiding this comment.
Hi @nikmel2803, thank you for your contribution! I added a few comments/questions!
plugins/node/opentelemetry-instrumentation-pg/test/pg-pool.test.ts
Outdated
Show resolved
Hide resolved
…ttributes and fix tests
…trib into fix-connection-string-in-pool
|
hey @deejay1! |
maryliag
reviewed
Feb 25, 2025
| @@ -138,13 +159,24 @@ export function getSemanticAttributesFromConnection( | |||
| } | |||
|
|
|||
| export function getSemanticAttributesFromPool(params: PgPoolOptionsParams) { | |||
| // const connectionParams = getConnectionParams(params); | |||
There was a problem hiding this comment.
looks like you forgot to remove this line
There was a problem hiding this comment.
oh, right! fixed
maryliag
approved these changes
Feb 28, 2025
deejay1
approved these changes
Feb 28, 2025
Merged
deejay1
pushed a commit
to deejay1/opentelemetry-js-contrib
that referenced
this pull request
Apr 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Fixes #1415
Short description of the changes
connectionStringparam in the PgPool constructorThe changes have also been tested in our org's telemetry setup.