Skip to content

Convert lettuce 5.1 reactive client tests from groovy to java #9876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 20, 2023

Conversation

jaydeluca
Copy link
Member

Related to #7195

@jaydeluca jaydeluca requested a review from a team November 15, 2023 22:42
Copy link
Contributor

@breedx-splk breedx-splk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a pretty clean port to me, thanks! I just had 2 small comments, otherwise looks good. Appreciate it!

@trask trask merged commit f6b63da into open-telemetry:main Nov 20, 2023
@jaydeluca jaydeluca deleted the convert-lettuce51-part2 branch January 6, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants