Convert Wicket groovy tests to java #9867
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
happyuser23
force-pushed
the
convert-wicket-test
branch
from
2a17ca7 to
ea42209
Compare
laurit
reviewed
Nov 17, 2023
| @@ -0,0 +1,119 @@ | |||
| /* | |||
There was a problem hiding this comment.
our convention is to place java tests in the same package as instrumentation code, groovy tests are usually in the root package
laurit
reviewed
Nov 17, 2023
| @@ -23,4 +23,7 @@ dependencies { | |||
|
|
|||
| testInstrumentation(project(":instrumentation:servlet:servlet-3.0:javaagent")) | |||
| testInstrumentation(project(":instrumentation:servlet:servlet-javax-common:javaagent")) | |||
|
|
|||
| // Wicket 9 requires Java 11 | |||
| latestDepTestLibrary("org.apache.wicket:wicket:8.+") | |||
There was a problem hiding this comment.
It is better to change the minimum required java version for latest dep tests instead of limiting the tested version range
Removing the
latestDepTestLibrary line would also be fine, we don't run latest dep tests with jdk8 so this won't fail in the CI
There was a problem hiding this comment.
testLatestDeps3 was failing.
Anyway, I updated as suggested to test with minimum required java version.
…ion in testLatestDeps
laurit
approved these changes
Nov 22, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Mar 12, 2024
Co-authored-by: Lauri Tulmin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #7195