Skip to content

Convert hibernate-3.3 tests from groovy to java #9025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Jul 26, 2023
Merged

Convert hibernate-3.3 tests from groovy to java #9025

merged 13 commits into from
Jul 26, 2023

Conversation

jaydeluca
Copy link
Member

Related to #7195

@jaydeluca jaydeluca requested a review from a team July 23, 2023 13:46
breedx-splk
breedx-splk approved these changes Jul 24, 2023
View reviewed changes
Copy link
Contributor

@breedx-splk breedx-splk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Not the easiest review. :) Looks to have the same coverage to me, and I appreciate eliminating some of the duplication that exists in the groovy implementation.

@trask trask merged commit 1c804ee into open-telemetry:main Jul 26, 2023
@trask
Copy link
Member

trask commented Jul 26, 2023

thx @jaydeluca!

@jaydeluca jaydeluca mentioned this pull request Sep 18, 2023
Closed
@jaydeluca jaydeluca deleted the hibernate-3-3 branch September 24, 2023 15:32
@jaydeluca jaydeluca mentioned this pull request Jul 1, 2024
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@breedx-splk breedx-splk breedx-splk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jaydeluca @trask @breedx-splk