Convert elasticsearch-rest-6.4 Test from groovy tp java. #8524
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: Convert elasticsearch-rest-6.4 Test from groovy tp java.
huange7
force-pushed
the
feat/convert_elasticsearch_test_to_java
branch
from
aef8c23 to
2065c77
Compare
laurit
reviewed
May 18, 2023
...ion/elasticsearch/elasticsearch-rest-6.4/javaagent/src/test/java/ElasticsearchRest6Test.java
Outdated
Show resolved
Hide resolved
laurit
reviewed
May 18, 2023
...ion/elasticsearch/elasticsearch-rest-6.4/javaagent/src/test/java/ElasticsearchRest6Test.java
Show resolved
Hide resolved
laurit
reviewed
May 18, 2023
...ion/elasticsearch/elasticsearch-rest-6.4/javaagent/src/test/java/ElasticsearchRest6Test.java
Show resolved
Hide resolved
laurit
approved these changes
May 18, 2023
|
why checks always in progress, is it normal? |
all done. ignore my comment |
@huange7 it was stuck downloading gradle caches, I canceled the build and reran the stuck jobs. |
mateuszrzeszutek
approved these changes
May 18, 2023
|
Thanks @huange7 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert elasticsearch-rest-6.4 Test from groovy tp java.