-
Notifications
You must be signed in to change notification settings - Fork 967
Convert kafka-clients unit test from groovy to java #7770
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert kafka-clients unit test from groovy to java #7770
Conversation
...t/java/io/opentelemetry/instrumentation/kafkaclients/KafkaClientPropagationDisabledTest.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a couple of comments, they're mostly about minor style issues. Overall it looks great, thanks @cuichenli !
...sting/src/main/java/io/opentelemetry/instrumentation/kafka/internal/KafkaClientBaseTest.java
Outdated
Show resolved
Hide resolved
...sting/src/main/java/io/opentelemetry/instrumentation/kafka/internal/KafkaClientBaseTest.java
Outdated
Show resolved
Hide resolved
...sting/src/main/java/io/opentelemetry/instrumentation/kafka/internal/KafkaClientBaseTest.java
Outdated
Show resolved
Hide resolved
...sting/src/main/java/io/opentelemetry/instrumentation/kafka/internal/KafkaClientBaseTest.java
Outdated
Show resolved
Hide resolved
...sting/src/main/java/io/opentelemetry/instrumentation/kafka/internal/KafkaClientBaseTest.java
Outdated
Show resolved
Hide resolved
...gent/src/test/java/io/opentelemetry/instrumentation/kafkaclients/KafkaClientDefaultTest.java
Outdated
Show resolved
Hide resolved
...gent/src/test/java/io/opentelemetry/instrumentation/kafkaclients/KafkaClientDefaultTest.java
Outdated
Show resolved
Hide resolved
...gent/src/test/java/io/opentelemetry/instrumentation/kafkaclients/KafkaClientDefaultTest.java
Outdated
Show resolved
Hide resolved
...t/java/io/opentelemetry/instrumentation/kafkaclients/KafkaClientPropagationDisabledTest.java
Show resolved
Hide resolved
testing.waitForTraces(1); | ||
testing.waitAndAssertTraces( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The waitAndAssertTraces()
method already waits for 1 completed trace, there should be no need to call waitForTraces()
explicitly
testing.waitForTraces(1); | |
testing.waitAndAssertTraces( | |
testing.waitAndAssertTraces( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed most testing.waitForTraces
but kept two where there is no testing.waitAndAssertTraces
Co-authored-by: Mateusz Rzeszutek <[email protected]>
@mateuszrzeszutek thanks for your comments, updated accordingly. please take a look again. thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @cuichenli !
...t/java/io/opentelemetry/instrumentation/kafkaclients/KafkaClientPropagationDisabledTest.java
Outdated
Show resolved
Hide resolved
.../java/io/opentelemetry/instrumentation/kafkaclients/KafkaClientSuppressReceiveSpansTest.java
Outdated
Show resolved
Hide resolved
...sting/src/main/java/io/opentelemetry/instrumentation/kafka/internal/KafkaClientBaseTest.java
Outdated
Show resolved
Hide resolved
The latest dep version tests are failing against an errorprone warning
You might want to add |
@mateuszrzeszutek thanks, all the tests passed |
No description provided.