Skip to content

Migrate some SQL sanitizer tests to java #7148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 15, 2022

Conversation

breedx-splk
Copy link
Contributor

Is there a way to tell spotless to ignore a file? I feel like some manual formatting would be an improvement in these....

@breedx-splk breedx-splk requested a review from a team November 12, 2022 01:17
@mateuszrzeszutek
Copy link
Member

Is there a way to tell spotless to ignore a file? I feel like some manual formatting would be an improvement in these....

I think you can use

// @formatter:off
// @formatter:on

for that purpose

@breedx-splk
Copy link
Contributor Author

// @formatter:off

Hmph, I tried it around a block and around the class and couldn't get it to work either way. 🤷🏻 Not a big deal.

@breedx-splk
Copy link
Contributor Author

Build errors look maven related. I don't have perms to re-run the failed jobs.

@trask
Copy link
Member

trask commented Nov 15, 2022

@breedx-splk heads up I merged main into your branch to fix the CI failures

Copy link
Member

@trask trask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

@trask trask enabled auto-merge (squash) November 15, 2022 04:43
@trask trask merged commit d4b29cf into open-telemetry:main Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants