move non-api classes to internal packages #11502
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
test native
|
@trask can you check? |
|
LGTM |
trask
reviewed
Jun 4, 2024
| @@ -1,5 +1,6 @@ | |||
| plugins { | |||
| id("otel.library-instrumentation") | |||
| id("otel.japicmp-conventions") | |||
There was a problem hiding this comment.
I don't think this will do anything without also marking the module as stable (and then the api diff files should get generated)
There was a problem hiding this comment.
should I make it stable or remove the line?
There was a problem hiding this comment.
Since this PR ended up doing other things I'd suggest removing this line and updating the PR title
There was a problem hiding this comment.
Then we can merge it and you can send a new PR to mark stable with the apidiff that we can review
zeitlinger
changed the title
laurit
approved these changes
Jun 5, 2024
zeitlinger
added a commit
to zeitlinger/opentelemetry-java-instrumentation
that referenced
this pull request
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.