Skip to content

Add support for Jetty 12 HTTP Client #9380

Closed
@jorge-branco-dt

Description

@jorge-branco-dt

Is your feature request related to a problem? Please describe.

We'd be looking for a solution similar to #2837 (Jetty 9 HTTP Client) but for Jetty 12, instead.
Unfortunately, Jetty 12 has gone through some serious API changes, and as such the previous instrumentation will definitely not work as it is.

Describe the solution you'd like

It seems the current Jetty 9.x implementation opted to instrument org.eclipse.jetty.client.HttpRequest.send(), which then calls org.eclipse.jetty.client.HttpClient,send(). HttpClient seems public so if I'm reading the situation correctly this may mean that calls to send() done directly through HttpClient may not currently be monitored..

On the other hand, in Jetty 12, HttpClient no longer seems to have a send() method, so one should indeed instrument org.eclipse.jetty.client.transport.HttpRequest.send(Response.CompleteListener) instead. Do note the change of package of HttpRequest, from org.eclipse.jetty.client to org.eclipse.jetty.client.transport.

Describe alternatives you've considered

No response

Additional context

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    contribution welcomeRequest makes sense, maintainers probably won't have time, contribution would be welcomeenhancementNew feature or requestnew instrumentation

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions