Closed
Description
Describe the bug
This relates to #6772 and the setup/environment is the same
Having disabled all additional parameters under logback-appender:
otel:
exporter:
otlp:
endpoint: ${OTLP_ENDPOINT}
protocol: ${OTLP_PROTOCOL}
metrics:
exporter: "otlp"
traces:
exporter: "otlp"
propagators: "tracecontext"
resource:
attributes:
environment: ${APP_ENV}
instrumentation:
logback-appender:
experimental-log-attributes: ${LOGBACK_EXPERIMENTAL_LOG_ATTRIBUTES}
experimental:
capture-mdc-attributes: false
capture-code-attributes: false
capture-marker-attribute: false
capture-logger-context-attributes: false
capture-key-value-pair-attributes: falseand explicitly excluded "log.body.parameters,log.body.template":
otel:
experimental:
resource:
disabled:
keys: "telemetry.sdk.language,telemetry.sdk.name,telemetry.sdk.version,log.body.parameters,log.body.template"After logging a message:
log.info("Service B about to call HelloService to do work that {}.", Boolean.TRUE.equals(fail) ? "fails" : "succeeds");
I end up with the following in Elastic:
I expect that:
Attributes.log.body.parameters
Attributes.log.body.template
would not be present in the structured JSON log.
Additional context
Full config yaml:
# Simulated environment variable injection
APP_ENV: dev
LOGBACK_EXPERIMENTAL_LOG_ATTRIBUTES: false # Enable the capture of experimental log attributes thread.name and thread.id
LOGBACK_CAPTURE_MDC_ATTRIBUTES: "*" # Comma separated list of MDC attributes to capture. Use the wildcard character * to capture all attributes.
LOGBACK_CAPTURE_CODE_ATTRIBUTES: false # Enable the capture of source code attributes. Note that capturing source code attributes at logging sites might add a performance overhead.
LOGBACK_CAPTURE_MARKER_ATTRIBUTE: false # Enable the capture of Logback markers as attributes.
LOGBACK_CAPTURE_LOGGER_CONTEXT_ATTRIBUTES: false # Enable the capture of Logback logger context properties as attributes. (This feature adds MDC properties as top level attributes instead of nested in _source)
LOGBACK_CAPTURE_KEY_VALUE_PAIR_ATTRIBUTES: false # Enable the capture of Logback key value pairs as attributes.
OTLP_PROTOCOL: grpc
OTLP_ENDPOINT: http://localhost:4317
spring:
application:
name: PoC-OpenTelemetry-REST-KAFKA
logging:
include-application-name: false
level:
io.opentelemetry: DEBUG
# NOTE: Always use comma separated lists for multiple values, this is how otel SDKs expect them
otel:
exporter:
otlp:
endpoint: ${OTLP_ENDPOINT}
protocol: ${OTLP_PROTOCOL}
metrics:
exporter: "otlp"
traces:
exporter: "otlp"
propagators: "tracecontext"
resource:
attributes:
environment: ${APP_ENV}
instrumentation:
logback-appender:
experimental-log-attributes: ${LOGBACK_EXPERIMENTAL_LOG_ATTRIBUTES}
experimental:
capture-mdc-attributes: ${LOGBACK_CAPTURE_MDC_ATTRIBUTES}
capture-code-attributes: ${LOGBACK_CAPTURE_CODE_ATTRIBUTES}
capture-marker-attribute: ${LOGBACK_CAPTURE_MARKER_ATTRIBUTE}
capture-logger-context-attributes: ${LOGBACK_CAPTURE_LOGGER_CONTEXT_ATTRIBUTES}
capture-key-value-pair-attributes: ${LOGBACK_CAPTURE_KEY_VALUE_PAIR_ATTRIBUTES}
java:
enabled:
resource:
providers: "io.opentelemetry.sdk.autoconfigure.internal.EnvironmentResourceProvider"
experimental:
resource:
disabled:
keys: "telemetry.sdk.language,telemetry.sdk.name,telemetry.sdk.version,log.body.parameters,log.body.template"
service:
name: ${spring.application.name} # absolutely MANDATORY for every service so telemetry data can be easily associated with the correct service through visual toolsClass producing the log:
import lombok.RequiredArgsConstructor;
import lombok.extern.slf4j.Slf4j;
import org.springframework.web.bind.annotation.GetMapping;
import org.springframework.web.bind.annotation.RequestParam;
import org.springframework.web.bind.annotation.RestController;
@RestController
@RequiredArgsConstructor
@Slf4j
public class HelloController {
private final HelloService helloService;
@GetMapping("/hello")
public String helloGet(@RequestParam(value = "fail", defaultValue = "false") Boolean fail) {
log.info("Service B about to call HelloService to do work that {}.", Boolean.TRUE.equals(fail) ? "fails" : "succeeds");
helloService.doServiceWorkSpanAnnotation(fail);
return "Hello from Service B!";
}
}