Changes AlwaysParentSample to ParentSample(fallback) #810
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrAlias
added
pkg:SDK
MrAlias
requested review from
Aneurysm9,
evantorrie,
jmacd,
lizthegrey and
paivagustavo
as code owners
Aneurysm9
approved these changes
Jun 10, 2020
lizthegrey
approved these changes
Jun 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To match the specification for the v0.5.0 release this changes the
AlwaysParentSamplesample function toParentSample(fallback Sampler). The functional change implements the functionality described in the specification.I don't think this has much affect in reality, because our sampling decisions already do this (https://github.com/open-telemetry/opentelemetry-go/blob/master/sdk/trace/span.go#L386-L419). I'm guessing the
TODOs in the specification when addressed will switch to how we are separating out these causes. Until then, I think we can add this to remain consistent with the specification and say we implement thev0.5.0specification.Addresses open-telemetry/opentelemetry-specification#609