Fixed OTLP example's accidental early close of exporter #807
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* The exp.Stop() as argument to handleErr is getting executed immediately. Wrap this with an anonymous func so that this argument is executed when the defer statement is activated. * From the "Tour of Go" docs on Defer: "The deferred call's arguments are evaluated immediately, but the function call is not executed until the surrounding function returns."
dcwangmit01
requested review from
Aneurysm9,
evantorrie,
jmacd,
lizthegrey,
MrAlias and
paivagustavo
as code owners
MrAlias
approved these changes
Jun 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
immediately. Wrap this with an anonymous func so that this
argument is executed when the defer statement is activated.
are evaluated immediately, but the function call is not executed
until the surrounding function returns."